Skip to content

Conversation

@zhuangqh
Copy link
Contributor

Signed-off-by: zhuangqh [email protected]

Ⅰ. Describe what this PR did

Schema should not point to a response object, or we will fail to generate model in latest version of go-swagger.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added kind/bug This is bug report for project size/S labels Jul 10, 2018
@codecov-io
Copy link

codecov-io commented Jul 10, 2018

Codecov Report

Merging #1712 into master will decrease coverage by 3.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1712      +/-   ##
==========================================
- Coverage   41.16%   37.76%   -3.41%     
==========================================
  Files         274      274              
  Lines       18089    19662    +1573     
==========================================
- Hits         7447     7425      -22     
- Misses       9729    11323    +1594     
- Partials      913      914       +1
Impacted Files Coverage Δ
daemon/mgr/snapshot.go 0% <0%> (-33.34%) ⬇️
ctrd/container.go 33.25% <0%> (-15.55%) ⬇️
daemon/mgr/container.go 34.97% <0%> (-15.26%) ⬇️
ctrd/image.go 65.43% <0%> (-12.04%) ⬇️
ctrd/client_opts.go 38.09% <0%> (-11.91%) ⬇️
cri/v1alpha2/cri_utils.go 18.06% <0%> (-6.51%) ⬇️
cri/v1alpha1/cri_utils.go 17.52% <0%> (-6.37%) ⬇️
ctrd/image_proxy_util.go 7.81% <0%> (-1.57%) ⬇️
cli/network.go 0% <0%> (ø) ⬆️
cli/common_flags.go 0% <0%> (ø) ⬆️
... and 5 more

@zhuangqh zhuangqh requested a review from fuweid July 10, 2018 09:41
@fuweid fuweid changed the title fix: schema point to a response object bugfix: schema point to a response object Jul 11, 2018
@fuweid fuweid merged commit 9a4047f into AliyunContainerService:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug This is bug report for project size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants