Skip to content

Conversation

@johanzhu
Copy link

@johanzhu johanzhu commented Jul 10, 2018

Ⅰ. Issue Description
Add unit-test for ValidateCPUQuota method which locate on apis/opts/cpu.go.
#1638
Ⅱ. Describe what happened
Add unit-test for ValidateCPUQuota method which locate on apis/opts/cpu.go
Ⅲ. Describe what you expected to happen
All test case passed.
Ⅳ. How to reproduce it (as minimally and precisely as possible)
Ⅴ. Anything else we need to know?
Baiji 262 group 2.

Ⅵ. Environment:
pouch version (use pouch version):go1.10.3 darwin/amd64
OS (e.g. from /etc/os-release): CentOS linux 7
Kernel (e.g. uname -a):3.10.0
Install tools: visualbox git go
Others:none

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @johanzhu
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@pouchrobot
Copy link
Collaborator

@johanzhu Thanks for your contribution. 🍻
Please sign off in each of your commits.

@codecov-io
Copy link

Codecov Report

Merging #1692 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1692      +/-   ##
==========================================
+ Coverage   41.16%   41.21%   +0.04%     
==========================================
  Files         274      274              
  Lines       18091    18091              
==========================================
+ Hits         7447     7456       +9     
+ Misses       9729     9723       -6     
+ Partials      915      912       -3
Impacted Files Coverage Δ
daemon/mgr/system.go 75% <0%> (-1.73%) ⬇️
ctrd/image.go 77.47% <0%> (-0.55%) ⬇️
daemon/mgr/container.go 50.23% <0%> (+0.15%) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
apis/server/utils.go 66.66% <0%> (+4.76%) ⬆️
apis/opts/cpu.go 50% <0%> (+50%) ⬆️

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jul 13, 2018
@allencloud allencloud merged commit 3a53801 into AliyunContainerService:master Jul 13, 2018
@allencloud allencloud changed the title Add unit-test for ValidateCPUQuota test: add unit-test for ValidateCPUQuota Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants