Skip to content

Conversation

@allencloud
Copy link
Collaborator

Signed-off-by: Allen Sun [email protected]

Ⅰ. Describe what this PR did

This pull request adds missing removal of container.

cc @Letty5411

Otherwise I will get CI failure like:

FAIL: /go/src/github.com/alibaba/pouch/test/cli_ps_test.go:76: PouchPsSuite.TestPsAll
/go/src/github.com/alibaba/pouch/test/cli_ps_test.go:86:
    // show running containers default
    c.Assert(lines[1], check.Equals, "")
... obtained string = "TestAPIRestartPauseContainer   4b8795   Up 1 minute   1 minute ago   registry.hub.docker.com/library/busybox:1.28   runc"
... expected string = ""

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

Codecov Report

Merging #1327 into master will decrease coverage by 0.89%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1327     +/-   ##
=========================================
- Coverage   17.33%   16.44%   -0.9%     
=========================================
  Files         189      182      -7     
  Lines       11815    11295    -520     
=========================================
- Hits         2048     1857    -191     
+ Misses       9619     9302    -317     
+ Partials      148      136     -12
Impacted Files Coverage Δ
pkg/utils/utils.go 69.79% <0%> (-2.6%) ⬇️
daemon/mgr/spec_mount.go 0% <0%> (ø) ⬆️
client/container.go 0% <0%> (ø) ⬆️
daemon/mgr/container.go 0% <0%> (ø) ⬆️
cli/exec.go 0% <0%> (ø) ⬆️
apis/server/container_bridge.go 0% <0%> (ø) ⬆️
ctrd/container.go 0% <0%> (ø) ⬆️
apis/server/router.go 0% <0%> (ø) ⬆️
daemon/logger/jsonfile/jsonfile_read.go
cri/src/cri_stream.go
... and 23 more

@HusterWan HusterWan merged commit ebb3a2b into AliyunContainerService:master May 15, 2018
@HusterWan
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants