bugfix: mount /sys/fs/cgroup into container

[fuweid]

Signed-off-by: Wei Fu [email protected]

Ⅰ. Describe what this PR did

Mount /sys/fs/cgroup into the container.

Ⅱ. Does this pull request fix one issue?

#1247

Ⅲ. Describe how you did it

Use oci.Spec and containerd will help us to do mount.

Ⅳ. Describe how to verify it

➜  pouch git:(bugfix_add_mount_spec_in_oci) pouch run -it registry.hub.docker.com/library/busybox:1.28 sh
/ # ls -al /sys/fs/cgroup/
total 0
dr-xr-xr-x   13 root     root           340 May 14 09:16 .
drwxr-xr-x    9 root     root             0 May 14 08:20 ..
drwxr-xr-x    2 root     root             0 May 14 09:16 blkio
lrwxrwxrwx    1 root     root            11 May 14 09:16 cpu -> cpu,cpuacct
drwxr-xr-x    2 root     root             0 May 14 09:16 cpu,cpuacct
lrwxrwxrwx    1 root     root            11 May 14 09:16 cpuacct -> cpu,cpuacct
drwxr-xr-x    2 root     root             0 May 14 09:16 cpuset
drwxr-xr-x    2 root     root             0 May 14 09:16 devices
drwxr-xr-x    2 root     root             0 May 14 09:16 freezer
drwxr-xr-x    2 root     root             0 May 14 09:16 hugetlb
drwxr-xr-x    2 root     root             0 May 14 09:16 memory
lrwxrwxrwx    1 root     root            16 May 14 09:16 net_cls -> net_cls,net_prio
drwxr-xr-x    2 root     root             0 May 14 09:16 net_cls,net_prio
lrwxrwxrwx    1 root     root            16 May 14 09:16 net_prio -> net_cls,net_prio
drwxr-xr-x    2 root     root             0 May 14 09:16 perf_event
drwxr-xr-x    2 root     root             0 May 14 09:16 pids
drwxr-xr-x    2 root     root             0 May 14 09:16 systemd

Ⅴ. Special notes for reviews

[Ace-Tang]

@fuweid , can you put these logic into file like daemon/mgr/spec_mount.go, since this is oci spec related ?

[fuweid]

@Ace-Tang I have updated and Please take a look. Thanks

[codecov-io]

Codecov Report

Merging #1314 into master will decrease coverage by 0.99%.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           master    #1314    +/-   ##
========================================
- Coverage    17.4%   16.41%    -1%     
========================================
  Files         189      183     -6     
  Lines       11767    11314   -453     
========================================
- Hits         2048     1857   -191     
+ Misses       9572     9321   -251     
+ Partials      147      136    -11

Impacted Files	Coverage Δ
ctrd/container.go	0% <ø> (ø)	⬆️
daemon/mgr/spec_mount.go	0% <0%> (ø)	⬆️
pkg/utils/utils.go	69.79% <0%> (-2.6%)	⬇️
apis/server/container_bridge.go	0% <0%> (ø)	⬆️
daemon/mgr/container.go	0% <0%> (ø)	⬆️
apis/server/router.go	0% <0%> (ø)	⬆️
daemon/mgr/container_logs.go
daemon/logger/jsonfile/utils.go
daemon/containerio/jsonfile.go
daemon/logger/jsonfile/jsonfile_read.go
... and 4 more

[Ace-Tang]

LGTM

[allencloud]

I think we could add an integration test case for this feature, right? @fuweid

[fuweid]

@allencloud , yes. I will do that in the following PR.But Reasonable.