bugfix: align with existing system #1263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1263 +/- ##
==========================================
- Coverage 15.26% 15.24% -0.02%
==========================================
Files 172 172
Lines 10699 10711 +12
==========================================
Hits 1633 1633
- Misses 8946 8958 +12
Partials 120 120
|
HusterWan
reviewed
May 2, 2018
cli/inspect.go
Outdated
| QuotaID string `json:"QuotaId,omitempty"` | ||
| } | ||
|
|
||
| // convContainerJSONToInspectContainerJSON convs ContainerJSON into inspectContainerJSON. |
There was a problem hiding this comment.
@HusterWan the conv is common used to represent the convert. I think it is ok here.
There was a problem hiding this comment.
Oh. I see. it is the comment...
Should show QuotaId instead of QuotaID. Signed-off-by: Wei Fu <[email protected]>
|
LGTM |
pouchrobot
added
the
LGTM
This was referenced May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should show QuotaId instead of QuotaID.
Signed-off-by: Wei Fu [email protected]
Ⅰ. Describe what this PR did
Align with existing system: change
QuotaIDtoQuotaId.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
NONE
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews