refactor: facilitate make.sh build #1261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1261 +/- ##
==========================================
+ Coverage 15.24% 15.31% +0.07%
==========================================
Files 172 172
Lines 10715 10665 -50
==========================================
Hits 1633 1633
+ Misses 8962 8912 -50
Partials 120 120
|
Contributor
|
@u2takey Thanks a lot for your PR @Letty5411 could your please review this PR? |
Collaborator
|
ping @sunyuan3 @Letty5411 Please take a look at and review this. |
Letty5411
reviewed
May 3, 2018
hack/make.sh
Outdated
| { | ||
| echo "Try installing containerd" | ||
| get_containerd_version | ||
| if [ "$CONTAINERD_VERSION" = "v1.0.3" ]; then |
Contributor
There was a problem hiding this comment.
= to be ==
And I would prefer using [[ ]], same comments for the following code.
sunyuan3
reviewed
May 3, 2018
hack/make.sh
Outdated
| echo "Nsenter already installed." | ||
| else | ||
| echo "Download and install nsenter." | ||
| apt-get install libncurses5-dev libslang2-dev gettext zlib1g-dev libselinux1-dev debhelper lsb-release pkg-config po-debconf autoconf automake autopoint libtool |
sunyuan3
reviewed
May 3, 2018
hack/make.sh
Outdated
| else | ||
| echo "Download and install nsenter." | ||
| apt-get install libncurses5-dev libslang2-dev gettext zlib1g-dev libselinux1-dev debhelper lsb-release pkg-config po-debconf autoconf automake autopoint libtool | ||
| wget https://www.kernel.org/pub/linux/utils/util-linux/v2.24/util-linux-2.24.1.tar.gz -P $TMP |
sunyuan3
reviewed
May 3, 2018
hack/make.sh
Outdated
| echo "Dumb-init already installed." | ||
| else | ||
| echo "Download and install dumb-init." | ||
| wget -O /tmp/dumb-init https://github.com/Yelp/dumb-init/releases/download/v1.2.1/dumb-init_1.2.1_amd64 |
check install status before do install binaries Signed-off-by: u2takey <[email protected]>
Contributor
Author
|
updated，ping @sunyuan3 @Letty5411 for review |
Contributor
|
LGTM |
pouchrobot
added
the
LGTM
This was referenced May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: u2takey [email protected]
Ⅰ. Describe what this PR did
facilitate make.sh build by checking install status before do install binaries