Skip to content

Conversation

@shaloulcy
Copy link
Contributor

The tmpfs volume is now mounted in the /etc/docker/plugins/tmpfs. It
should be mounted in /mnt/tmpfs

Signed-off-by: Eric Li [email protected]

Ⅰ. Describe what this PR did

The tmpfs volume is now mounted in the /etc/docker/plugins/tmpfs. It
should be mounted in /mnt/tmpfs

fix some misspells

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

  1. create tmpfs volume
root@ubuntu-1:~# pouch volume create -d tmpfs -n tmp_vol1
CreatedAt:    2018-4-28 11:17:36
Driver:       tmpfs
Labels:       map[]
Mountpoint:   /mnt/tmpfs/tmp_vol1
Name:         tmp_vol1
Scope:        
Status:       map[sifter:Default]
  1. run container with the volume
root@ubuntu-1:~# pouch run -v tmp_vol1:/test -d reg.docker.alibaba-inc.com/redis
3a841472c493934885cbed99dd56c75ac48fbfaa32a9f3626e5e9701d5cb82a0
  1. see the mount path
root@ubuntu-1:~# mount |grep tmp_vol1
shm on /mnt/tmpfs/tmp_vol1 type tmpfs (rw,nosuid,nodev,noexec,relatime,size=0k)

Ⅴ. Special notes for reviews

The tmpfs volume is now mounted in the /etc/docker/plugins/tmpfs. It
should be mounted in /mnt/tmpfs

Signed-off-by: Eric Li <[email protected]>
@pouchrobot pouchrobot added areas/storage kind/bug This is bug report for project size/XS labels Apr 28, 2018
@codecov-io
Copy link

Codecov Report

Merging #1251 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1251      +/-   ##
==========================================
+ Coverage   15.27%   15.36%   +0.08%     
==========================================
  Files         172      172              
  Lines       10691    10629      -62     
==========================================
  Hits         1633     1633              
+ Misses       8938     8876      -62     
  Partials      120      120
Impacted Files Coverage Δ
daemon/mgr/volume.go 0% <ø> (ø) ⬆️
daemon/mgr/network.go 3.47% <0%> (-0.01%) ⬇️
cli/cli.go 0% <0%> (ø) ⬆️
daemon/mgr/container.go 0% <0%> (ø) ⬆️
cli/run.go 0% <0%> (ø) ⬆️
cli/update.go 0% <0%> (ø) ⬆️
daemon/config/config.go 10% <0%> (+2.1%) ⬆️

@HusterWan HusterWan requested a review from rudyfly May 2, 2018 10:58
@rudyfly
Copy link
Collaborator

rudyfly commented May 2, 2018

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label May 2, 2018
@rudyfly rudyfly merged commit 91d92d3 into AliyunContainerService:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

areas/storage kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants