bugfix: add newline for id when create container #1237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HusterWan
reviewed
Apr 27, 2018
| if len(result.Warnings) != 0 { | ||
| fmt.Printf("WARNING: %s \n", strings.Join(result.Warnings, "\n")) | ||
| } | ||
| fmt.Printf(result.ID) |
Contributor
There was a problem hiding this comment.
Can we add test case to lock this ? :)
Contributor
|
CI failed because there exists length check of container ID. If it is necessary to change the way of print, change the corresponding test case. |
Signed-off-by: Wei Fu <[email protected]>
Contributor
Author
|
@ZouRui89 I have updated the case. Please help me to review. Thanks! FYI @HusterWan |
Contributor
|
LGTM |
pouchrobot
added
the
LGTM
Codecov Report
@@ Coverage Diff @@
## master #1237 +/- ##
=======================================
Coverage 15.36% 15.36%
=======================================
Files 172 172
Lines 10630 10630
=======================================
Hits 1633 1633
Misses 8877 8877
Partials 120 120
|
This was referenced May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wei Fu [email protected]
Ⅰ. Describe what this PR did
add newline for id when create container
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how you did it
use
fmt.PrintlnⅣ. Describe how to verify it
Ⅴ. Special notes for reviews
NONE