Skip to content

Conversation

@rudyfly
Copy link
Collaborator

@rudyfly rudyfly commented Apr 25, 2018

Ⅰ. Describe what this PR did

fix volume size without unit, such as size=1024 will be failed.

Ⅱ. Does this pull request fix one issue?

NONO

Ⅲ. Describe how you did it

check the size has unit or not, if it has no unit size, we will add "B" at the end of size.

Ⅳ. Describe how to verify it

# pouch volume create -d local -o size=1048576 -n test
Mountpoint:   /data/pouch/volume/test
Name:         test
Scope:
Status:       map[sifter:Default size:1048576 mount:/data/pouch/volume]
CreatedAt:    2018-4-25 21:28:44
Driver:       local
Labels:       map[]

Ⅴ. Special notes for reviews

Signed-off-by: Rudy Zhang [email protected]

@pouchrobot pouchrobot added areas/storage kind/bug This is bug report for project size/S labels Apr 25, 2018
@rudyfly rudyfly requested a review from yyb196 April 25, 2018 13:33
fix volume size without unit, such as size=1024 will be failed.

Signed-off-by: Rudy Zhang <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #1215 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1215      +/-   ##
=========================================
+ Coverage   15.66%   15.7%   +0.04%     
=========================================
  Files         171     171              
  Lines       10393   10398       +5     
=========================================
+ Hits         1628    1633       +5     
  Misses       8645    8645              
  Partials      120     120
Impacted Files Coverage Δ
pkg/bytefmt/bytefmt.go 89.83% <100%> (+0.94%) ⬆️

@yyb196
Copy link
Collaborator

yyb196 commented Apr 25, 2018

LGTM

@Letty5411
Copy link
Contributor

tests LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 25, 2018
@yyb196 yyb196 merged commit 7237551 into AliyunContainerService:master Apr 25, 2018
@rudyfly rudyfly deleted the volume-size branch October 29, 2018 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

areas/storage kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants