bugfix: failed to create 'volumefrom' container #1161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
old container has bind directory into container, such as "-v /tmp:/tmp", when use 'volumefrom' to create new container, it will be failed when setup volumes. Signed-off-by: Rudy Zhang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1161 +/- ##
==========================================
+ Coverage 16.03% 16.06% +0.02%
==========================================
Files 174 173 -1
Lines 9995 9929 -66
==========================================
- Hits 1603 1595 -8
+ Misses 8275 8217 -58
Partials 117 117
|
|
I still suggest that add an integration test to cover this. @rudyfly |
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
old container has bind directory into container, such as "-v /tmp:/tmp",
when use 'volumefrom' to create new container, it will be failed when
setup volumes.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Signed-off-by: Rudy Zhang [email protected]