Skip to content

Conversation

@Ace-Tang
Copy link
Contributor

not all type can be casting to string

Fixes: #1083

Signed-off-by: Ace-Tang [email protected]

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

not all type can be casting to string

Fixes: #1083

Signed-off-by: Ace-Tang <[email protected]>
@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Apr 10, 2018
@allencloud
Copy link
Collaborator

Could you help to review and test this?
I am also wondering if we could a test case to cover this? @Letty5411

@Letty5411
Copy link
Contributor

@allencloud Yes, that's how I find this bug.

@Letty5411
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 11, 2018
@Letty5411 Letty5411 merged commit 204c39c into AliyunContainerService:master Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] panic when checking the conflict of config file and parameter in pouchd

4 participants