test: add mock test for system_version #1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zou Rui <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1004 +/- ##
==========================================
+ Coverage 13.67% 13.81% +0.14%
==========================================
Files 124 125 +1
Lines 8395 8395
==========================================
+ Hits 1148 1160 +12
+ Misses 7148 7135 -13
- Partials 99 100 +1
Continue to review full report at Codecov.
|
allencloud
reviewed
Mar 29, 2018
| HTTPCli: httpClient, | ||
| } | ||
|
|
||
| if _, err := client.SystemVersion(context.Background()); err != nil { |
There was a problem hiding this comment.
you can assert the value returned by the function.
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zou Rui [email protected]
Ⅰ. Describe what this PR did
add mock test for system_version on client side
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews