Skip to content

Conversation

@ClarkXia
Copy link
Collaborator

Use regex rule instead of function, it will reduce build time.

@ClarkXia ClarkXia requested a review from luhc228 December 27, 2023 08:36
@ClarkXia ClarkXia added the need review Need Review label Dec 27, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (00685f6) 79.93% compared to head (81a7b4a) 79.84%.

Files Patch % Lines
packages/ice/src/config.ts 55.55% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release/next    #6719      +/-   ##
================================================
- Coverage         79.93%   79.84%   -0.10%     
================================================
  Files               218      218              
  Lines             19011    19015       +4     
  Branches           2454     2451       -3     
================================================
- Hits              15197    15183      -14     
- Misses             3783     3801      +18     
  Partials             31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClarkXia ClarkXia merged commit ef52f81 into release/next Dec 28, 2023
@ClarkXia ClarkXia deleted the fix/pack branch December 28, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need review Need Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants