feat(facetOrdering): implement hidden facets in SFFV #6648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We read the last results' facet ordering and apply hidden facets (not facet ordering) to the results array. nbHits does not need to be changed as search for facet values doesn't return that key. [CR-8645]
Haroenv
requested review from
a team,
aymeric-giraudet and
shaejaz
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 130f1bb:
|
Less than a kb more, but it impacts all over
aymeric-giraudet
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We read the last results' facet ordering and apply hidden facets (not facet ordering) to the results array.
nbHits does not need to be changed as search for facet values doesn't return that key.
CR-8645
Result
hidden facets according to facetOrdering of the previous "full search" response are taken in account in search for facet values.
the lastResponse is always the most correct one if the index matches, if the previous search was for another index we do nothing