Skip to content

feat(js): introduce Translations API#581

Merged
shortcuts merged 6 commits intonextfrom
feat/translations
May 11, 2021
Merged

feat(js): introduce Translations API#581
shortcuts merged 6 commits intonextfrom
feat/translations

Conversation

@shortcuts
Copy link
Copy Markdown
Member

@shortcuts shortcuts commented May 10, 2021

Summary

Adds a new property in the AutocompleteOptions called Translations, which overrides the default text values.

Preview

Steps

  • Implementation
  • Tests
  • Doc

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented May 10, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cb07b02:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-react-renderer Configuration
@algolia/autocomplete-example-starter-algolia Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-voice-search Configuration
@algolia/autocomplete-example-vue Configuration

@shortcuts
Copy link
Copy Markdown
Member Author

Let me know if you think of any other raw text/aria labels that should be translated

Comment thread packages/autocomplete-js/src/__tests__/api.test.ts Outdated
Comment thread packages/autocomplete-js/src/__tests__/translations.test.ts
Comment thread packages/autocomplete-js/src/types/AutocompleteOptions.ts Outdated
@francoischalifour francoischalifour changed the title feat(js): introduce Translations API feat(js): introduce Translations API May 11, 2021
Copy link
Copy Markdown
Contributor

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants