Skip to content

fix(js): render noResults template when openOnFocus is true#573

Merged
shortcuts merged 2 commits intonextfrom
fix/openOnFocus-noResults
May 6, 2021
Merged

fix(js): render noResults template when openOnFocus is true#573
shortcuts merged 2 commits intonextfrom
fix/openOnFocus-noResults

Conversation

@shortcuts
Copy link
Copy Markdown
Member

Summary
On an empty query, nothing is rendered when openOnFocus is true and a noResults template is provided.

live reproduction:

  • Focus input: nothing is rendered.
  • Type something: noResults template is rendered.

Result
The noResults template is rendered on an empty query with openOnFocus: true

@shortcuts shortcuts force-pushed the fix/openOnFocus-noResults branch from dbe9a13 to 5921f9b Compare May 5, 2021 13:59
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented May 5, 2021

Copy link
Copy Markdown
Member

@sarahdayan sarahdayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

Comment thread packages/autocomplete-js/src/render.tsx Outdated
Comment thread packages/autocomplete-js/src/render.tsx Outdated
@shortcuts shortcuts merged commit f2154c8 into next May 6, 2021
@shortcuts shortcuts deleted the fix/openOnFocus-noResults branch May 6, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants