feat(js): scroll to top when query changes#457
Merged
francoischalifour merged 3 commits intonextfrom Feb 19, 2021
Merged
Conversation
Member
|
Could it make sense to expose this as a boolean (e.g. |
Contributor
Author
|
@shortcuts When would you want to not have this behavior? |
Member
|
@francoischalifour in some e-commerce cases I guess. I could imagine some side-by-side sections (like https://www.ldlc.com/) where you'd probably don't want to scroll all of them but handle it separately. |
Contributor
Author
|
@shortcuts That's exactly why we have this That makes me think that we should use |
shortcuts
approved these changes
Feb 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This scrolls to the top of the panel when the query changes (i.e., when new results come in) so that users don't have to.
How
We introduce a new CSS utility class in the theme called
.aa-Panel--Scrollablewhich hints Autocomplete that this is the container responsible for displaying the list of items.By default, this CSS class is attached to
.aa-PanelLayout, but when we introduce the Preview Panel plugin, it will be attached to the left child of.aa-PanelLayout.Whenever the query changes, we scroll to the top of this scrollable container.
Preview
Before
After