fix(autocomplete): filter out empty collections in aria-controls#1302
Merged
Haroenv merged 1 commit intoalgolia:nextfrom Feb 4, 2025
Merged
fix(autocomplete): filter out empty collections in aria-controls#1302Haroenv merged 1 commit intoalgolia:nextfrom
Haroenv merged 1 commit intoalgolia:nextfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 07b7635:
|
Haroenv
approved these changes
Feb 4, 2025
Contributor
|
Thanks @mxschmitt, will release this soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue that the
aria-controlsvalue was filled with a reference to empty collections. We can make an assumption to skip them, since recent/favorite collections don't get rendered for 0 size collections. See algolia/docsearch#2485 for more information.Result
Its covered with tests in algolia/docsearch#2485.