fix(insights): split large view event payloads into multiple chunks#1087
Merged
fix(insights): split large view event payloads into multiple chunks#1087
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 245437b:
|
Haroenv
approved these changes
Feb 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Insights events containing more than 20 object IDs fail to be processed by the Insights API. This can happen with Autocomplete when an Algolia source shows more than 20 items (using
hitsPerPagefor example).This PR ensures payloads containing more than 20 items are correctly split into smaller chunks that can be processed by the Insights API.
It also fixes another issue when only events from the first Insights-compatible plugin and/or source would be sent. For example, when typing on an Autocomplete that has both the Query Suggestions plugin and one or multiple Algolia sources, only the view events from the Query Suggestions are sent.