fix: avoid swallowing errors and return promise chain instead

Author: sarahdayan

packages/autocomplete-core/src/onInput.ts

@@ -169,7 +169,5 @@ export function onInput<TItem extends BaseItem>({
       }
     });
 
-  store.pendingRequests.add(request);
-
-  return request;
+  return store.pendingRequests.add(request);
 }

packages/autocomplete-core/src/utils/__tests__/createCancelablePromiseList.test.ts

@@ -31,7 +31,7 @@ describe('createCancelablePromiseList', () => {
     const cancelablePromiseList = createCancelablePromiseList();
     const cancelablePromise = createCancelablePromise.reject();
 
-    cancelablePromiseList.add(cancelablePromise);
+    cancelablePromiseList.add(cancelablePromise).catch(noop);
 
     expect(cancelablePromiseList.isEmpty()).toBe(false);
 
@@ -59,9 +59,9 @@ describe('createCancelablePromiseList', () => {
     const cancelablePromise2 = createCancelablePromise.reject();
     const cancelablePromise3 = createCancelablePromise(noop);
 
-    cancelablePromiseList.add(cancelablePromise1);
-    cancelablePromiseList.add(cancelablePromise2);
-    cancelablePromiseList.add(cancelablePromise3);
+    cancelablePromiseList.add(cancelablePromise1).catch(noop);
+    cancelablePromiseList.add(cancelablePromise2).catch(noop);
+    cancelablePromiseList.add(cancelablePromise3).catch(noop);
 
     expect(cancelablePromise1.isCanceled()).toBe(false);
     expect(cancelablePromise2.isCanceled()).toBe(false);

packages/autocomplete-core/src/utils/createCancelablePromiseList.ts

@@ -1,9 +1,7 @@
-import { noop } from '@algolia/autocomplete-shared';
-
 import { CancelablePromise } from '.';
 
 export type CancelablePromiseList<TValue> = {
-  add(cancelablePromise: CancelablePromise<TValue>): void;
+  add(cancelablePromise: CancelablePromise<TValue>): CancelablePromise<TValue>;
   cancelAll(): void;
   isEmpty(): boolean;
 };
@@ -17,7 +15,7 @@ export function createCancelablePromiseList<
     add(cancelablePromise) {
       list.push(cancelablePromise);
 
-      cancelablePromise.catch(noop).finally(() => {
+      return cancelablePromise.finally(() => {
         list = list.filter((item) => item !== cancelablePromise);
       });
     },

packages/autocomplete-js/src/__tests__/autocomplete.test.ts

@@ -1,7 +1,11 @@
 import * as autocompleteShared from '@algolia/autocomplete-shared';
 import { fireEvent, waitFor } from '@testing-library/dom';
 
-import { castToJestMock, createMatchMedia } from '../../../../test/utils';
+import {
+  castToJestMock,
+  createMatchMedia,
+  runAllMicroTasks,
+} from '../../../../test/utils';
 import { autocomplete } from '../autocomplete';
 
 jest.mock('@algolia/autocomplete-shared', () => {
@@ -524,7 +528,7 @@ describe('autocomplete-js', () => {
     expect(input).toHaveValue('Query');
   });
 
-  test('renders on input', () => {
+  test('renders on input', async () => {
     const container = document.createElement('div');
     autocomplete<{ label: string }>({
       id: 'autocomplete',
@@ -554,6 +558,8 @@ describe('autocomplete-js', () => {
 
     fireEvent.input(input, { target: { value: 'a' } });
 
+    await runAllMicroTasks();
+
     expect(input).toHaveValue('a');
   });
 });