feat(js): rename class names#351
Conversation
This renames the class names to better reflect the structure of the DOM. Feel free to suggest any changes. BREAKING CHANGE
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 73285f5:
|
| </form> | ||
| <div | ||
| class="aa-Dropdown" | ||
| class="aa-ListContainer" |
There was a problem hiding this comment.
Any better alternative to this?
There was a problem hiding this comment.
I don't think dropdown is really a bad name
There was a problem hiding this comment.
It's going to have ul, right? Then.. I guess ListContainer is good.
There was a problem hiding this comment.
I think something with "results" could also work
There was a problem hiding this comment.
@Haroenv "dropdown" loses its sense in the context of modal searches like DocSearch v3, so I'm unsure.
There was a problem hiding this comment.
ListsContainer or ResultsContainer seems best to me. Maybe also something like Suggestions, Collections or Sources, since you renamed that?
There was a problem hiding this comment.
It's important to note that this term will also replace the main getDropdownProps API:
Perhaps "Panel" makes sense?
There was a problem hiding this comment.
Panel came back several times, Menu isn't a bad name neither. Except you won't have to wait to get your order served :p
There was a problem hiding this comment.
I renamed "ListContainer" to "Panel" in a600ed2. That's good enough for now.
Haroenv
left a comment
Haroenv
left a comment
There was a problem hiding this comment.
I guess some things can still change, but good enough for now indeed
4 participants
This renames the class names to better reflect the structure of the DOM.
Feel free to suggest any changes.