fix(zepto): apply patch to handle read-only event#263
Merged
Haroenv merged 1 commit intoalgolia:masterfrom Oct 31, 2018
Merged
Conversation
Contributor
|
Yes, can you revert the dist files please? It’s only updated at publish. Thanks for this PR!! |
Kocal
force-pushed
the
fix/zepto-data-event
branch
from
50db225 to
533373a
Compare
Contributor
Author
|
Dist files have been removed, I also added a gif in the original post 👍 |
Haroenv
approved these changes
Oct 31, 2018
Contributor
Haroenv
left a comment
Haroenv
left a comment
There was a problem hiding this comment.
this looks correct to me, thanks for doing this PR!
Contributor
Author
|
Thanks for merging. Sorry for asking, but do you have an idea on when a new version will be published? |
Contributor
|
I will release Autocomplete tomorrow |
Contributor
Author
|
Okay, thanks you! 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies this patch from @ymoran00.
Some events are read only and zepto can not update
dataproperty.I can't reproduce it at the moment because I am on smartphone, but this problem was really painful.
Also it seems that it doesn't break anything, this patch worked fine on our project at work (it uses place.js).
Result
By the way, should I remove build files from this pull request?I wanted to ship them but they were desynchronized with actual source files.
The build is done before publishing on npm right?
Thanks.