Skip to content

Commit 045bacb

Browse files
committed
Update to unicode v13.0.0
1 parent 1434f80 commit 045bacb

File tree

5 files changed

+12
-7
lines changed

5 files changed

+12
-7
lines changed

.pylintrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ never-returning-functions=sys.exit
115115

116116
# Format style used to check logging format string. `old` means using %
117117
# formatting, `new` is for `{}` formatting,and `fstr` is for f-strings.
118-
logging-format-style=fstr
118+
logging-format-style=new
119119

120120
# Logging modules to check that the string format arguments are in logging
121121
# function parameter format.

dev.requirements.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
# setup.py requirements
22
-e .
33

4+
# Updating from source emoji data
5+
requests>=2.25.1,<3.0.0
6+
47
# Testing
58
pytest>=5.3.5,<6.0.0
69
pytest-cov>=2.8.1,<3.0.0

emoji_data_python/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,9 @@
1010
# Read json data on module load to be cached
1111
with open(path.join(path.dirname(__file__), "data/emoji.json"), "r") as full_data:
1212
# Load and parse emoji data from json into EmojiChar objects
13-
# pylint: disable=invalid-name
1413
emoji_data = [EmojiChar(data_blob) for data_blob in json.loads(full_data.read())] # type: List[EmojiChar]
1514

1615
# Build a cached dictionary of short names for quicker access, short code keys are normalized with underscores
17-
# pylint: disable=invalid-name
1816
emoji_short_names = {emoji.short_name.replace("-", "_"): emoji for emoji in emoji_data} # type: Dict[str, EmojiChar]
1917

2018
# Add other short names if they are not already used as a primary short name for an other emoji

emoji_data_python/data/emoji.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

tests/test_search.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
import unittest
22

3-
from emoji_data_python import all_doublebyte, find_by_shortname, find_by_name
3+
from emoji_data_python import all_doublebyte, find_by_shortname, find_by_name, emoji_data
44

55

66
class SearchTestCase(unittest.TestCase):
7+
def test_all_emoji_length(self):
8+
self.assertEqual(1810, len(emoji_data))
9+
710
def test_all_double_bytes(self):
811
self.assertEqual('HASH KEY', all_doublebyte()[0].name) # HASH_KEY is the first double byte char
912

@@ -12,9 +15,10 @@ def test_find_by_shortname(self):
1215
self.assertEqual('WAVING HAND SIGN', find_by_shortname('wave')[0].name)
1316

1417
def test_find_by_shortname_unique(self):
15-
self.assertEqual(27, len(find_by_shortname('heart')))
18+
self.assertEqual(28, len(find_by_shortname('heart')))
1619
self.assertEqual(14, len(find_by_shortname('moon')))
1720

1821
def test_find_by_name(self):
19-
self.assertEqual('COUPLE WITH HEART', find_by_name('heart')[0].name)
22+
self.assertEqual('COUPLE WITH HEART: MAN, MAN', find_by_name('heart')[0].name)
23+
self.assertEqual('SUNRISE OVER MOUNTAINS', find_by_name('sun')[0].name)
2024
self.assertEqual(3, len(find_by_name('earth')))

0 commit comments

Comments
 (0)