Remove newCandidate, check for matches separately

Author: prashantv

context.go

@@ -685,18 +685,23 @@ func flipBoolValue(value reflect.Value) error {
 func (c *Context) parseFlag(flags []*Flag, match string) (err error) {
 	candidates := []string{}
 
-	newCandidate := func(s string) bool {
-		candidates = append(candidates, s)
-		return s == match
-	}
-
 	for _, flag := range flags {
-		matched := newCandidate("--" + flag.Name)
+		flagCandidates := []string{}
+		flagCandidates = append(flagCandidates, "--"+flag.Name)
 		if flag.Short != 0 {
-			matched = matched || newCandidate("-"+string(flag.Short))
+			flagCandidates = append(flagCandidates, "-"+string(flag.Short))
 		}
 		for _, alias := range flag.Aliases {
-			matched = matched || newCandidate("--"+alias)
+			flagCandidates = append(flagCandidates, "--"+alias)
+		}
+		candidates = append(candidates, flagCandidates...)
+
+		var matched bool
+		for _, candidate := range flagCandidates {
+			if candidate == match {
+				matched = true
+				break
+			}
 		}
 
 		neg := "--no-" + flag.Name