Skip to content

Commit 4bcd6b3

Browse files
ellenspalbertogg
authored andcommitted
Fix SKR 1.4 LCD / ADC Keypad sanity-check (MarlinFirmware#18670)
1 parent 52727a0 commit 4bcd6b3

2 files changed

Lines changed: 10 additions & 6 deletions

File tree

Marlin/src/pins/lpc1768/pins_BTT_SKR_V1_3.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,10 @@
261261
#define LCD_PINS_ENABLE EXPA1_03_PIN
262262
#define LCD_PINS_D4 EXPA1_05_PIN
263263

264+
#elif HAS_ADC_BUTTONS
265+
266+
#error "ADC BUTTONS do not work unmodifed on SKR 1.3, The ADC ports cannot take more than 3.3v."
267+
264268
#else // !CR10_STOCKDISPLAY
265269

266270
#define LCD_PINS_RS EXPA1_07_PIN

Marlin/src/pins/lpc1768/pins_BTT_SKR_V1_4.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@
250250
#define LCD_PINS_ENABLE P1_23
251251
#define LCD_PINS_D4 P1_21
252252

253-
#elif HAS_GRAPHICAL_LCD
253+
#else
254254

255255
#define BTN_ENC P0_28 // (58) open-drain
256256
#define LCD_PINS_RS P1_19
@@ -312,14 +312,14 @@
312312

313313
#endif // !FYSETC_MINI_12864
314314

315-
#elif HAS_CHARACTER_LCD
316-
317-
#error "Character LCD not yet supported for SKR 1.4."
318-
319-
#endif
315+
#endif // HAS_GRAPHICAL_LCD
320316

321317
#endif // HAS_SPI_LCD
322318

319+
#if HAS_ADC_BUTTONS
320+
#error "ADC BUTTONS do not work unmodifed on SKR 1.4, The ADC ports cannot take more than 3.3v."
321+
#endif
322+
323323
//
324324
// Neopixel LED
325325
//

0 commit comments

Comments
 (0)