Skip to content

Commit 034733f

Browse files
authored
refactor: remove AWS dynamo integration (apache#407)
Closes apache#373.
1 parent f422dce commit 034733f

File tree

8 files changed

+6
-690
lines changed

8 files changed

+6
-690
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
# under the License.
1717

1818
---
19-
2019
name: CI
2120

2221
concurrency:
@@ -100,8 +99,8 @@ jobs:
10099
AWS_SECRET_ACCESS_KEY: test
101100
AWS_ENDPOINT: http://localhost:4566
102101
AWS_ALLOW_HTTP: true
103-
AWS_COPY_IF_NOT_EXISTS: dynamo:test-table:2000
104-
AWS_CONDITIONAL_PUT: dynamo:test-table:2000
102+
AWS_COPY_IF_NOT_EXISTS: multipart
103+
AWS_CONDITIONAL_PUT: etag
105104
AWS_SERVER_SIDE_ENCRYPTION: aws:kms
106105
HTTP_URL: "http://localhost:8080"
107106
GOOGLE_BUCKET: test-bucket
@@ -132,7 +131,6 @@ jobs:
132131
aws --endpoint-url=http://localhost:4566 s3 mb s3://test-bucket-for-spawn
133132
aws --endpoint-url=http://localhost:4566 s3 mb s3://test-bucket-for-checksum
134133
aws --endpoint-url=http://localhost:4566 s3api create-bucket --bucket test-object-lock --object-lock-enabled-for-bucket
135-
aws --endpoint-url=http://localhost:4566 dynamodb create-table --table-name test-table --key-schema AttributeName=path,KeyType=HASH AttributeName=etag,KeyType=RANGE --attribute-definitions AttributeName=path,AttributeType=S AttributeName=etag,AttributeType=S --provisioned-throughput ReadCapacityUnits=5,WriteCapacityUnits=5
136134
137135
KMS_KEY=$(aws --endpoint-url=http://localhost:4566 kms create-key --description "test key")
138136
echo "AWS_SSE_KMS_KEY_ID=$(echo $KMS_KEY | jq -r .KeyMetadata.KeyId)" >> $GITHUB_ENV

src/aws/builder.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1079,7 +1079,6 @@ impl AmazonS3Builder {
10791079

10801080
let config = S3Config {
10811081
region,
1082-
endpoint: self.endpoint,
10831082
bucket,
10841083
bucket_endpoint,
10851084
credentials,

src/aws/client.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,6 @@ impl From<DeleteError> for Error {
192192
#[derive(Debug)]
193193
pub(crate) struct S3Config {
194194
pub region: String,
195-
pub endpoint: Option<String>,
196195
pub bucket: String,
197196
pub bucket_endpoint: String,
198197
pub credentials: AwsCredentialProvider,

0 commit comments

Comments
 (0)