Order type fields by oridnal to keep the same order on multiple platforms. (#236)

Co-authored-by: Gregorius Soedharmo <[email protected]>

Author: object

src/Hyperion.Tests/Bugs.cs

@@ -489,5 +489,23 @@ public void WritesManifestEvenIfKnown()
             Assert.DoesNotContain("System.Collections.Generic.Dictionary", text);
             Assert.Equal(msg, res);
         }
+
+        #region Issue 348
+
+        class FieldsToOrder
+        {
+            public string A2;
+            public string a1;
+        }
+
+        [Fact]
+        public void ShouldOrderFieldsByOrdinal()
+        {
+            string[] expected = { "A2", "a1" };
+            var actual = typeof(FieldsToOrder).GetFieldInfosForType().Select(x => x.Name).ToArray();
+            Assert.Equal(expected, actual);
+        }
+
+        #endregion
     }
 }

src/Hyperion/Extensions/ReflectionEx.cs

@@ -48,7 +48,7 @@ public static FieldInfo[] GetFieldInfosForType(this Type type)
                 fieldInfos.AddRange(tfields);
                 current = current.GetTypeInfo().BaseType;
             }
-            var fields = fieldInfos.OrderBy(f => f.Name).ToArray();
+            var fields = fieldInfos.OrderBy(f => f.Name, StringComparer.Ordinal).ToArray();
             return fields;
         }
     }