Skip to content

Conversation

@asprouse
Copy link
Contributor

What issue does this pull request resolve?

Fixes #1899

What changes did you make?

Use root schemaEnv when resolving references in oneOf

Is there anything that requires more attention while reviewing?

No this should be a simple fix

Copy link

@mcat mcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@epoberezkin
Copy link
Member

Great!

@epoberezkin epoberezkin merged commit 95b15b6 into ajv-validator:master Feb 24, 2022
@asprouse
Copy link
Contributor Author

@epoberezkin I know you are probably very busy, but is it possible to cut a 8.10.1 release so that this fix is available via npm?

@metinogurlu
Copy link

@epoberezkin I am waiting for the next release too, do you have any prediction about that?

@epoberezkin
Copy link
Member

right, sorry - it was nagging me that I didn't do it - thanks for the pings - will do today/tomorrow!

@epoberezkin
Copy link
Member

It’s released now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Using discriminator in a definition causes failure to compile if oneOf contains a reference

4 participants