Skip to content

Add WebExt Lint as CI job#187

Open
rugk wants to merge 3 commits into
ajayyy:masterfrom
rugk:patch-1
Open

Add WebExt Lint as CI job#187
rugk wants to merge 3 commits into
ajayyy:masterfrom
rugk:patch-1

Conversation

@rugk
Copy link
Copy Markdown

@rugk rugk commented Nov 9, 2023

Inspired by https://github.com/rugk/awesome-emoji-picker/blob/main/.github/workflows/webext-lint.yml

As far as I see you don't run that anywhere else, so may this be a good idea?

  • I agree to license my contribution under LGPL-3.0 or my contribution is from another project with a license compatible with LGPL-3.0

To test this pull request, follow the instructions in the wiki.


Inspired by https://github.com/rugk/awesome-emoji-picker/blob/main/.github/workflows/webext-lint.yml

As far as I see you don't run that anywhere else, so may this be a good idea?
Comment thread .github/workflows/.github/workflows/webext-lint.yml Outdated
rugk added a commit to rugk/SponsorBlock that referenced this pull request Nov 9, 2023
Inspired by https://github.com/rugk/awesome-emoji-picker/blob/main/.github/workflows/webext-lint.yml

As far as I see you don't run that anywhere else, so may this be a good idea?

Same as ajayyy/DeArrow#187
@ajayyy
Copy link
Copy Markdown
Owner

ajayyy commented Nov 9, 2023

Warnings will need to be dealt with before merging. The only place this does get run right now is by AMO themselves when I upload a build.

@rugk
Copy link
Copy Markdown
Author

rugk commented Feb 16, 2024

Workflows need approval before they can run, so one cannot even see the warnings online at GitHub at least.

Copy link
Copy Markdown

@Fmichi50 Fmichi50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants