Add support for ECS Tasks #44
Conversation
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
- Coverage 97.22% 96.98% -0.25%
==========================================
Files 46 51 +5
Lines 1009 1094 +85
==========================================
+ Hits 981 1061 +80
- Misses 28 33 +5
Continue to review full report at Codecov.
|
ChristopheBougere
left a comment
ChristopheBougere
left a comment
There was a problem hiding this comment.
Awesome work 👏👏👏
I'm just wondering if the output of a sync task shouldn't be the result of describeTask, so that it can be used later. Any guess on that?
| } | ||
|
|
||
| async waitForEcsTaskToFinish(ecs, parameters, taskArn) { | ||
| // TODO: I've seen a history event called TaskSubmitted... |
There was a problem hiding this comment.
Not much documentation about events history, sadly :/
Best way to check is to have a look to a real execution in the stepfunctions console to see which one has been added
There was a problem hiding this comment.
Yea, I ran it and that's where I got the list of events I have. I did see TaskSubmitted, but there was no info on when that's supposed to fire... It's probably safer to omit it and leave the TODO until we have docs on these events rather than fire it at the wrong time, but I'm open to other suggestions.
|
Perfect! |
|
Thanks! I'll try out the new release and let you know how it works for us. |
2 participants
Partially fixes #43. This adds support for calling ECS Tasks from step functions state machines:
task.jsso that it's an "abstract" class with aninvokemethod that must be overridden by subclasses representing each different type of task (Lambda, Activity, ECS).task-lambda.jsand the existing Activity code was moved totask-activity.js.task-ecs.jsfor this ECS work.