Skip to content

Commit fce8c31

Browse files
committed
Fix #118 Store link is missing rel="noopener"
1 parent 4b17597 commit fce8c31

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/smartbanner.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ export default class SmartBanner {
126126
<div class="smartbanner__info__price">${this.options.price}${this.priceSuffix}</div>
127127
</div>
128128
</div>
129-
<a href="${this.buttonUrl}" target="_blank" class="smartbanner__button"><span class="smartbanner__button__label">${this.options.button}</span></a>
129+
<a href="${this.buttonUrl}" target="_blank" class="smartbanner__button" rel="noopener"><span class="smartbanner__button__label">${this.options.button}</span></a>
130130
</div>`;
131131
}
132132

test/spec/smartbanner_spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ describe('SmartBanner', function() {
126126
<div class="smartbanner__info__price">FREE - On the App Store</div>
127127
</div>
128128
</div>
129-
<a href="https://itunes.apple.com/us/genre/ios/id36?mt=8" target="_blank" class="smartbanner__button"><span class="smartbanner__button__label">View</span></a>
129+
<a href="https://itunes.apple.com/us/genre/ios/id36?mt=8" target="_blank" class="smartbanner__button" rel="noopener"><span class="smartbanner__button__label">View</span></a>
130130
</div>`;
131131

132132
const ANDROID_BODY = `<div class="smartbanner smartbanner--android js_smartbanner">
@@ -139,7 +139,7 @@ describe('SmartBanner', function() {
139139
<div class="smartbanner__info__price">FREE - In Google Play</div>
140140
</div>
141141
</div>
142-
<a href="https://play.google.com/store" target="_blank" class="smartbanner__button"><span class="smartbanner__button__label">View</span></a>
142+
<a href="https://play.google.com/store" target="_blank" class="smartbanner__button" rel="noopener"><span class="smartbanner__button__label">View</span></a>
143143
</div>`;
144144

145145
const ANDROID_CUSTOM_DESIGN_BODY = `<div class="smartbanner smartbanner--custom-design js_smartbanner">
@@ -152,7 +152,7 @@ describe('SmartBanner', function() {
152152
<div class="smartbanner__info__price">FREE - In Google Play</div>
153153
</div>
154154
</div>
155-
<a href="https://play.google.com/store" target="_blank" class="smartbanner__button"><span class="smartbanner__button__label">View</span></a>
155+
<a href="https://play.google.com/store" target="_blank" class="smartbanner__button" rel="noopener"><span class="smartbanner__button__label">View</span></a>
156156
</div>`;
157157

158158
const USER_AGENT_IPHONE_IOS8 = 'Mozilla/5.0 (iPhone; CPU iPhone OS 8_0_2 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) Version/8.0 Mobile/12A405 Safari/600.1.4';

0 commit comments

Comments
 (0)