Skip to content

Commit a438a06

Browse files
authored
Merge pull request #189 from sgotti/datamanager_dont_wait_etcd_down
datamanager tests: don't wait for etcd down
2 parents b8d12d7 + eafa4d1 commit a438a06

1 file changed

Lines changed: 3 additions & 12 deletions

File tree

internal/datamanager/datamanager_test.go

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ func TestEtcdReset(t *testing.T) {
7575
t.Fatalf("unexpected err: %v", err)
7676
}
7777
tetcd := setupEtcd(t, etcdDir)
78-
defer shutdownEtcd(tetcd)
7978

8079
ctx, cancel := context.WithCancel(context.Background())
8180

@@ -131,9 +130,7 @@ func TestEtcdReset(t *testing.T) {
131130
// Reset etcd
132131
t.Logf("stopping etcd")
133132
shutdownEtcd(tetcd)
134-
if err := tetcd.WaitDown(20 * time.Second); err != nil {
135-
t.Fatalf("unexpected err: %v", err)
136-
}
133+
137134
t.Logf("resetting etcd")
138135
os.RemoveAll(etcdDir)
139136
t.Logf("starting etcd")
@@ -185,7 +182,6 @@ func TestEtcdResetWalsGap(t *testing.T) {
185182
t.Fatalf("unexpected err: %v", err)
186183
}
187184
tetcd := setupEtcd(t, etcdDir)
188-
defer shutdownEtcd(tetcd)
189185

190186
ctx, cancel := context.WithCancel(context.Background())
191187

@@ -241,9 +237,7 @@ func TestEtcdResetWalsGap(t *testing.T) {
241237
t.Logf("stopping etcd")
242238
// Reset etcd
243239
shutdownEtcd(tetcd)
244-
if err := tetcd.WaitDown(10 * time.Second); err != nil {
245-
t.Fatalf("unexpected err: %v", err)
246-
}
240+
247241
t.Logf("resetting etcd")
248242
os.RemoveAll(etcdDir)
249243
t.Logf("starting etcd")
@@ -1489,7 +1483,6 @@ func TestExportImport(t *testing.T) {
14891483
t.Fatalf("unexpected err: %v", err)
14901484
}
14911485
tetcd := setupEtcd(t, etcdDir)
1492-
defer shutdownEtcd(tetcd)
14931486

14941487
ctx, cancel := context.WithCancel(context.Background())
14951488

@@ -1589,9 +1582,7 @@ func TestExportImport(t *testing.T) {
15891582
t.Logf("stopping etcd")
15901583
// Reset etcd
15911584
shutdownEtcd(tetcd)
1592-
if err := tetcd.WaitDown(10 * time.Second); err != nil {
1593-
t.Fatalf("unexpected err: %v", err)
1594-
}
1585+
15951586
t.Logf("resetting etcd")
15961587
os.RemoveAll(etcdDir)
15971588
t.Logf("starting etcd")

0 commit comments

Comments
 (0)