Fix multisource_rag_app #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change response.stream.aclose() to response.aclose() in summarizer.py to properly close async responses. - Update model configuration from async_qwen_config to qwen_config for DialogAgent types in agent_config_dict.json to fix incorrect async model assignment. - Ensure database directory exists before creating the logging table in db_logging.py. - Fix recursive call bug in logging.py by changing the warning method to call logger.error instead of itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Fix multisource_rag_app
about: Bug fixes for model config assignment, async resource handling, and logging in multisource_rag_app
Description
Checklist
Please check the following items before code is ready to be reviewed.