feat(provider): Fix provider_id conflicts and remove connection test in custom provider#1234
Merged
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes custom provider creation behavior to automatically resolve provider_id conflicts (instead of throwing), and updates the console UI to hide the “Test connection” action for custom providers.
Changes:
- Backend: auto-renames conflicting/duplicate custom provider IDs during creation and returns the resolved
ProviderInfo. - CLI: prints the resolved provider id (and requested id if it changed) after creating a custom provider.
- Console: hides the “Test connection” button for custom providers; updates unit tests to match the new conflict-resolution behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/copaw/providers/provider_manager.py |
Adds ID conflict resolution for custom providers and updates custom provider creation payload. |
src/copaw/cli/providers_cmd.py |
Captures/prints returned ProviderInfo so the CLI reflects any auto-renamed IDs. |
console/src/pages/Settings/Models/components/modals/ProviderConfigModal.tsx |
Hides “Test connection” button for custom providers. |
tests/unit/providers/test_provider_manager.py |
Updates tests to assert auto-renaming behavior for conflicts/duplicates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
xieyxclack
approved these changes
Mar 11, 2026
hh0592821
pushed a commit
to hh0592821/CoPaw
that referenced
this pull request
Mar 12, 2026
…in custom provider (agentscope-ai#1234)
tudan110
pushed a commit
to tudan110/QwenPaw
that referenced
this pull request
Apr 4, 2026
…in custom provider (agentscope-ai#1234)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimized the handling logic for
provider_idconflicts, no longer throwing exceptions but directly renaming the ID. (Does not support dashscope-intl and coding-intl subdomains of aliyuncs #1145)Hides the connection test button on the custom provider configuration page, as many custom inference services do not provide the necessary testing interfaces. (桌面端配置MiniMax模型无法连通,修改配置文件可以连通但无法正常使用 #1175)
Type of Change
Component(s) Affected
Checklist
pre-commit run --all-fileslocally and it passespytestor as relevant) and they passTesting
[How to test these changes]
Local Verification Evidence
Additional Notes
[Optional: any other context]