Skip to content

Conversation

@mrxz
Copy link
Contributor

@mrxz mrxz commented Jun 2, 2025

Fixes #5734

Description:
Probe lights used an instance of THREE.CubeTextureLoader to create a CubeTexture which was then fed into the LightProbeGenerator. With #5454 the possible values for srcs for an envMap were broadened, meaning they were no longer guaranteed to be URLs, but could also contain HTMLImageElement.

The loadCubeMapTexture method on the material system already handles all possible values. This PR replaces the light component to use loadCubeMapTexture instead of manually using a CubeTextureLoader instance.

Changes proposed:

  • Use loadCubeMapTexture when loading a cubemap texture for light probes

@dmarcos
Copy link
Member

dmarcos commented Jun 2, 2025

Thank you!

@dmarcos dmarcos merged commit 241a775 into aframevr:master Jun 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Probe Lighting Errors On Load and Doesn't Contribute to Scene Lighting

2 participants