Use loadCubeMapTexture instead of CubeTextureLoader for light probes
#5735
+8
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5734
Description:
Probe lights used an instance of
THREE.CubeTextureLoaderto create aCubeTexturewhich was then fed into theLightProbeGenerator. With #5454 the possible values forsrcsfor an envMap were broadened, meaning they were no longer guaranteed to be URLs, but could also containHTMLImageElement.The
loadCubeMapTexturemethod on the material system already handles all possible values. This PR replaces thelightcomponent to useloadCubeMapTextureinstead of manually using aCubeTextureLoaderinstance.Changes proposed:
loadCubeMapTexturewhen loading a cubemap texture for light probes