Skip to content

Conversation

@vincentfretin
Copy link
Contributor

Description:

Set texture.generateMipmaps according to specified minFilter.
Since mrdoob/three.js#29677 that's included since three r170 you need to set texture.generateMipmaps to false explicitly if using minFilter 'linear' or 'nearest' to not generate mipmaps.

Changes proposed:

  • add texture.generateMipmaps = minFilter !== THREE.NearestFilter && minFilter !== THREE.LinearFilter;

@mrxz
Copy link
Contributor

mrxz commented May 24, 2025

Change looks good to me. Especially now that we explicitly expose mag/minFilter as properties, it's nice to avoid generating mipmaps when we know they aren't needed.

@dmarcos
Copy link
Member

dmarcos commented May 27, 2025

Thank you

@dmarcos dmarcos merged commit 2fd4d30 into aframevr:master May 27, 2025
3 checks passed
@vincentfretin vincentfretin deleted the set-generateMipmaps branch May 27, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants