Skip to content

Conversation

@ngokevin
Copy link
Member

Description:

Porting some critical code to faster/cleaner object3D API for transform updates.

Changes proposed:

  • Use 3js object3D API for transforms in look-controls for bit of speed.
  • Don't need to re-allocate object this.savedPose every enter VR.

@dmarcos
Copy link
Member

dmarcos commented Dec 25, 2017

I have a PR that touched this logic to fix the user height issues. Some parts of this might end up obsolete. I put it on hold and I’ll submit mine today or tomorrow

@dmarcos
Copy link
Member

dmarcos commented Jan 24, 2018

#3327 delegates pose update to the VRManager from THREE that changes the object3D directly. It makes this PR redundant.

@dmarcos dmarcos closed this Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants