Skip to content

fix component build data when previousData is object with null prop #3021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2017
Merged

fix component build data when previousData is object with null prop #3021

merged 1 commit into from
Sep 3, 2017

Conversation

@ngokevin
Copy link
Member

@ngokevin ngokevin commented Sep 2, 2017

Description:

Fixes null has no properties type error.

Changes proposed:

  • Check for truthiness before running .constructor.

@ngokevin
Copy link
Member Author

ngokevin commented Sep 3, 2017

@donmccurdy r? if you're around

@dmarcos
Copy link
Member

dmarcos commented Sep 3, 2017

Thanks!

@dmarcos dmarcos merged commit f3f345f into aframevr:master Sep 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ngokevin @dmarcos