From 9e1af5ad6e01e8b8206af27a986edc7fd6c763c6 Mon Sep 17 00:00:00 2001 From: Kyle Phillips Date: Tue, 1 Aug 2017 13:18:27 -0400 Subject: [PATCH 1/2] fix missing detail property in a-scene onVRPresentChange --- src/core/scene/a-scene.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/scene/a-scene.js b/src/core/scene/a-scene.js index bbab81ba777..1e140439e86 100644 --- a/src/core/scene/a-scene.js +++ b/src/core/scene/a-scene.js @@ -306,7 +306,7 @@ module.exports.AScene = registerElement('a-scene', { onVRPresentChange: { value: function (evt) { // Entering VR. - if (evt.display.isPresenting) { + if (evt.detail.display.isPresenting) { this.enterVR(true); return; } From 0c56937af1e56e3dfb23025226615ac88e08d2f6 Mon Sep 17 00:00:00 2001 From: Kyle Phillips Date: Tue, 1 Aug 2017 13:54:22 -0400 Subject: [PATCH 2/2] fix onVRPresentChange to check event and event.detail for display --- src/core/scene/a-scene.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/core/scene/a-scene.js b/src/core/scene/a-scene.js index 1e140439e86..969247f2603 100644 --- a/src/core/scene/a-scene.js +++ b/src/core/scene/a-scene.js @@ -305,8 +305,10 @@ module.exports.AScene = registerElement('a-scene', { */ onVRPresentChange: { value: function (evt) { + // Polyfill places display inside the detail property + var display = evt.display || evt.detail.display; // Entering VR. - if (evt.detail.display.isPresenting) { + if (display.isPresenting) { this.enterVR(true); return; }