Maybe more accurate fractional height

devongovett · devongovett · commit 8ffa7646e85b · 2025-10-01T20:43:06.000-07:00
diff --git a/packages/@react-spectrum/overlays/src/Underlay.tsx b/packages/@react-spectrum/overlays/src/Underlay.tsx
@@ -25,7 +25,7 @@ export function Underlay({isOpen, isTransparent, ...otherProps}: UnderlayProps):
   if (typeof document !== 'undefined') {
     let scrollingElement = isScrollable(document.body) ? document.body : document.scrollingElement || document.documentElement;
     // Prevent Firefox from adding scrollbars when the page has a fractional height.
-    let fractionalHeightDifference = scrollingElement.clientHeight - scrollingElement.getBoundingClientRect().height;
+    let fractionalHeightDifference = scrollingElement.getBoundingClientRect().height % 1;
     pageHeight = scrollingElement.scrollHeight - fractionalHeightDifference;
   }
 
diff --git a/packages/react-aria-components/src/Modal.tsx b/packages/react-aria-components/src/Modal.tsx
@@ -175,7 +175,7 @@ function ModalOverlayInner({UNSTABLE_portalContainer, ...props}: ModalOverlayInn
   if (typeof document !== 'undefined') {
     let scrollingElement = isScrollable(document.body) ? document.body : document.scrollingElement || document.documentElement;
     // Prevent Firefox from adding scrollbars when the page has a fractional height.
-    let fractionalHeightDifference = scrollingElement.clientHeight - scrollingElement.getBoundingClientRect().height;
+    let fractionalHeightDifference = scrollingElement.getBoundingClientRect().height % 1;
     pageHeight = scrollingElement.scrollHeight - fractionalHeightDifference;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ export function Underlay({isOpen, isTransparent, ...otherProps}: UnderlayProps):`
`25`	`25`	`if (typeof document !== 'undefined') {`
`26`	`26`	`let scrollingElement = isScrollable(document.body) ? document.body : document.scrollingElement \|\| document.documentElement;`
`27`	`27`	`// Prevent Firefox from adding scrollbars when the page has a fractional height.`
`28`		`- let fractionalHeightDifference = scrollingElement.clientHeight - scrollingElement.getBoundingClientRect().height;`
	`28`	`+ let fractionalHeightDifference = scrollingElement.getBoundingClientRect().height % 1;`
`29`	`29`	`pageHeight = scrollingElement.scrollHeight - fractionalHeightDifference;`
`30`	`30`	`}`
`31`	`31`
Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ function ModalOverlayInner({UNSTABLE_portalContainer, ...props}: ModalOverlayInn`
`175`	`175`	`if (typeof document !== 'undefined') {`
`176`	`176`	`let scrollingElement = isScrollable(document.body) ? document.body : document.scrollingElement \|\| document.documentElement;`
`177`	`177`	`// Prevent Firefox from adding scrollbars when the page has a fractional height.`
`178`		`- let fractionalHeightDifference = scrollingElement.clientHeight - scrollingElement.getBoundingClientRect().height;`
	`178`	`+ let fractionalHeightDifference = scrollingElement.getBoundingClientRect().height % 1;`
`179`	`179`	`pageHeight = scrollingElement.scrollHeight - fractionalHeightDifference;`
`180`	`180`	`}`
`181`	`181`