From cb611c819987b59638716e0afde61d6e9012de2e Mon Sep 17 00:00:00 2001 From: phoet Date: Tue, 6 Feb 2018 15:23:12 +0100 Subject: [PATCH] removing some complexity --- lib/localer/data.rb | 13 +++++++++---- lib/localer/data/checker.rb | 18 ------------------ lib/localer/data/missing_translations.rb | 18 ------------------ 3 files changed, 9 insertions(+), 40 deletions(-) delete mode 100644 lib/localer/data/checker.rb delete mode 100644 lib/localer/data/missing_translations.rb diff --git a/lib/localer/data.rb b/lib/localer/data.rb index bc92e34..f690754 100644 --- a/lib/localer/data.rb +++ b/lib/localer/data.rb @@ -1,9 +1,7 @@ # frozen_string_literal: true require_relative "data/service" -require_relative "data/checker" require_relative "data/processor" -require_relative "data/missing_translations" module Localer # Stores translations and provides @@ -21,11 +19,18 @@ def initialize(*args) end def complete? - Checker.call(self) + each do |_locale, _key, value| + return false if value.nil? + end + true end def missing_translations - MissingTranslations.call(self) + missing = [] + each do |locale, key, value| + missing.push("#{locale}#{key}") if value.nil? + end + missing end def each diff --git a/lib/localer/data/checker.rb b/lib/localer/data/checker.rb deleted file mode 100644 index 291fe17..0000000 --- a/lib/localer/data/checker.rb +++ /dev/null @@ -1,18 +0,0 @@ -# frozen_string_literal: true - -module Localer - class Data - # Check missing translations - # Returns true if no missing translations found, otherwise false - class Checker < Service - param :data - - def call - data.each do |_locale, _key, value| - return false if value.nil? - end - true - end - end - end -end diff --git a/lib/localer/data/missing_translations.rb b/lib/localer/data/missing_translations.rb deleted file mode 100644 index 05ec4b1..0000000 --- a/lib/localer/data/missing_translations.rb +++ /dev/null @@ -1,18 +0,0 @@ -# frozen_string_literal: true - -module Localer - class Data - # A service that returns array of missing translations - class MissingTranslations < Service - param :data - - def call - missing = [] - data.each do |locale, key, value| - missing.push("#{locale}#{key}") if value.nil? - end - missing - end - end - end -end