-
-
Notifications
You must be signed in to change notification settings - Fork 71
let django handle the timezone #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
==========================================
- Coverage 95.20% 95.18% -0.02%
==========================================
Files 49 49
Lines 5751 5732 -19
==========================================
- Hits 5475 5456 -19
Misses 276 276
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d8c7d72 to
ea85dd0
Compare
|
I am fine with the PR. We can merge it if you are fine too. |
9f500c5 to
9c52d80
Compare
|
And since we don't manually manipulate timezone anymore, we don't use pytz anymore and we can now remove it. I had to edit a commit already committed for the git history to remain clean sorry, you will probably have to do a |
Don't worry, git manipulations is part of my daily routine nowadays because of my line of work, learning it the hard way. |
I'll try to fix the codecov error and then we merge. I'm fine with it too. Wondering if it's not time to do a 3.4.0 release... |
|
I think it's worth doing a 3.4.0 release: when you change a lot of things, it's good to release often otherwise a release brings too many changes and people never migrate. |
It's just this line in init.py file to change. GitHub Actions will take care of the rest and create the release. |
Current time zone handling of django-appointment is incorrect.
settings.TIME_ZONEis a fallback from the past for when correct time zone support was not present in Django. Now timezones works perfectly fine and you are not suppose to use the TIME_ZONE. Just useget_current_timezone()and let django handle the current user's timezone for you.