Skip to content

Admin can change appointment's staff member #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamspd merged 6 commits into from
Mar 26, 2024
Merged

Admin can change appointment's staff member #159

adamspd merged 6 commits into from
Mar 26, 2024

Conversation

@adamspd
Copy link
Owner

@adamspd adamspd commented Mar 25, 2024

No description provided.

@adamspd adamspd linked an issue Mar 25, 2024 that may be closed by this pull request
Admin can change appointment's staff member #150
Closed
@adamspd adamspd self-assigned this Mar 25, 2024
@adamspd adamspd added enhancement New feature or request and removed user-interface labels Mar 25, 2024
@github-actions github-actions bot added the tests label Mar 25, 2024
@codecov
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 68.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 95.20%. Comparing base (56166ab) to head (cb530c1).
Report is 2 commits behind head on main.

Files Patch % Lines
appointment/views_admin.py 37.50% 5 Missing ⚠️
appointment/services.py 76.92% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   95.32%   95.20%   -0.13%     
==========================================
  Files          49       49              
  Lines        5728     5751      +23     
==========================================
+ Hits         5460     5475      +15     
- Misses        268      276       +8
Flag Coverage Δ
unittests 95.20% <68.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamspd adamspd merged commit 0768cdb into main Mar 26, 2024
@adamspd adamspd deleted the 150-admin-can-change-appointments-staff-member branch March 26, 2024 09:52
adamspd added a commit that referenced this pull request Mar 31, 2024
@adamspd
Admin can't create new appointment if no staff member object is linke…
098345d 
…d to them

Staff admin can't display appointment object because of #159 logic
Service list changes when staff member changes (by admin).
@adamspd adamspd mentioned this pull request Mar 31, 2024
Merged
adamspd added a commit that referenced this pull request Mar 31, 2024
@adamspd
Merge pull request #168 from adamspd/fix/staff-member-display-appt-an…
5ea883b 
…d-admin-all-rights

Fix #159 bug introductions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@adamspd adamspd

Labels

enhancement New feature or request feature tests user-interface

Projects

None yet

Milestone

Fix bugs and all promised features.

Development

Successfully merging this pull request may close these issues.

Admin can change appointment's staff member

2 participants

@adamspd