Don't automatically pad sharedSecret

adam-fowler · adam-fowler · commit a3b0fca899cc · 2024-10-31T11:18:27.000Z
diff --git a/Sources/SRP/client.swift b/Sources/SRP/client.swift
@@ -198,7 +198,7 @@ public extension SRPClient {
         // calculate S = (B - k*g^x)^(a+u*x)
         let S = (serverPublicKey.number - configuration.k * configuration.g.power(x, modulus: configuration.N)).power(clientKeys.private.number + u * x, modulus: configuration.N)
 
-        return .init(S, padding: configuration.sizeN)
+        return SRPKey(S)
     }
 
     /// generate password verifier
diff --git a/Sources/SRP/server.swift b/Sources/SRP/server.swift
@@ -59,7 +59,7 @@ public struct SRPServer<H: HashFunction> {
         // calculate S
         let S = ((clientPublicKey.number * verifier.number.power(u, modulus: configuration.N)).power(serverKeys.private.number, modulus: configuration.N))
 
-        return SRPKey(S, padding: configuration.sizeN)
+        return SRPKey(S)
     }
 
     /// verify proof that client has shared secret and return a server verification proof. If verification fails a `invalidClientCode` error is thrown

Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ public extension SRPClient {`
`198`	`198`	`// calculate S = (B - kg^x)^(a+ux)`
`199`	`199`	`let S = (serverPublicKey.number - configuration.k * configuration.g.power(x, modulus: configuration.N)).power(clientKeys.private.number + u * x, modulus: configuration.N)`
`200`	`200`
`201`		`- return .init(S, padding: configuration.sizeN)`
	`201`	`+ return SRPKey(S)`
`202`	`202`	`}`
`203`	`203`
`204`	`204`	`/// generate password verifier`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ public struct SRPServer<H: HashFunction> {`
`59`	`59`	`// calculate S`
`60`	`60`	`let S = ((clientPublicKey.number * verifier.number.power(u, modulus: configuration.N)).power(serverKeys.private.number, modulus: configuration.N))`
`61`	`61`
`62`		`- return SRPKey(S, padding: configuration.sizeN)`
	`62`	`+ return SRPKey(S)`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	/// verify proof that client has shared secret and return a server verification proof. If verification fails a `invalidClientCode` error is thrown