Add note regarding pull_request_target to README.md
#669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is a big gotcha that should be called out in the documentation. I've been trying to debug why the workflow did not run for a long time, until I finally understood the underlying issue.
silverwind
commented
Sep 8, 2023
marko-zivic-93
approved these changes
Sep 11, 2023
|
I just ran into the same problem and it took me a while to find the root cause — @silverwind or @marko-zivic-93, could you merge this PR so it's easier for the next person? 👍 |
|
I ran into the same problem today. It's because dependabot made a pr to upgrade the labeler from v4 to v5 |
MaksimZhukov
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I think this is a big gotcha that should be called out in the documentation. I've been trying to debug why the workflow did not run in go-gitea/gitea#26962 for a long time, until I finally understood the underlying issue.
Check list: