Skip to content

Conversation

@ChristopherHX
Copy link
Contributor

E.g. if GoGitAction Cache had a fetch failure this error did not trigger report jobResult Failure.

Also the error has been not printed until the last message before exit of act.

  • adds tests for both corner cases

Closes #59

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 2 0 0.01s
✅ REPOSITORY gitleaks yes no 2.75s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 9.36s
✅ REPOSITORY secretlint yes no 1.23s
✅ REPOSITORY trivy-sbom yes no 0.39s
✅ REPOSITORY trufflehog yes no 3.94s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/runner/job_executor.go 91.66% 1 Missing ⚠️
Files with missing lines Coverage Δ
pkg/runner/job_executor.go 87.74% <91.66%> (+0.72%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ChristopherHX ChristopherHX marked this pull request as ready for review March 26, 2025 15:48
@ChristopherHX ChristopherHX merged commit b46fe42 into main Mar 27, 2025
7 checks passed
@ChristopherHX ChristopherHX deleted the fix-reporting-fetch-failure-as-job-error branch March 27, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure to fetch action not reported as job failure

2 participants