fix: coerce booleans to numbers for comparison in exprparser (#1030)

Co-Authored-By: Markus Wolf <[email protected]>

Co-authored-by: Markus Wolf <[email protected]>
Co-authored-by: Casey Lee <[email protected]>

Author: 3 people

pkg/exprparser/interpreter.go

@@ -305,6 +305,8 @@ func (impl *interperterImpl) compareValues(leftValue reflect.Value, rightValue r
 	}
 
 	switch leftValue.Kind() {
+	case reflect.Bool:
+		return impl.compareNumber(float64(impl.coerceToNumber(leftValue).Int()), float64(impl.coerceToNumber(rightValue).Int()), kind)
 	case reflect.String:
 		return impl.compareString(strings.ToLower(leftValue.String()), strings.ToLower(rightValue.String()), kind)
 
@@ -323,7 +325,7 @@ func (impl *interperterImpl) compareValues(leftValue reflect.Value, rightValue r
 		return impl.compareNumber(leftValue.Float(), rightValue.Float(), kind)
 
 	default:
-		return nil, fmt.Errorf("TODO: evaluateCompare not implemented %+v", reflect.TypeOf(leftValue))
+		return nil, fmt.Errorf("TODO: evaluateCompare not implemented! left: %+v, right: %+v", leftValue.Kind(), rightValue.Kind())
 	}
 }
 

pkg/exprparser/interpreter_test.go

@@ -121,6 +121,10 @@ func TestOperatorsCompare(t *testing.T) {
 		{`0 == '' }}`, true, "string-0-coercion-alt"},
 		{`3 == '3' }}`, true, "string-3-coercion-alt"},
 		{`'TEST' == 'test' }}`, true, "string-casing"},
+		{"true > false }}", true, "bool-greater-than"},
+		{"true >= false }}", true, "bool-greater-than-eq"},
+		{"true >= true }}", true, "bool-greater-than-1"},
+		{"true != false }}", true, "bool-not-equal"},
 		{`fromJSON('{}') < 2 }}`, false, "object-with-less"},
 		{`fromJSON('{}') < fromJSON('[]') }}`, false, "object/arr-with-lt"},
 		{`fromJSON('{}') > fromJSON('[]') }}`, false, "object/arr-with-gt"},