Skip to content

Commit 74b0fe8

Browse files
fix: (#2075)
network-scoped alias is supported only for containers in user defined networks Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
1 parent 18b4714 commit 74b0fe8

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

pkg/container/docker_run.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -447,7 +447,9 @@ func (cr *containerReference) create(capAdd []string, capDrop []string) common.E
447447

448448
var networkingConfig *network.NetworkingConfig
449449
logger.Debugf("input.NetworkAliases ==> %v", input.NetworkAliases)
450-
if hostConfig.NetworkMode.IsUserDefined() && len(input.NetworkAliases) > 0 {
450+
n := hostConfig.NetworkMode
451+
// TODO: use IsUserDefined() once it's windows implementation matches the unix one
452+
if !n.IsDefault() && !n.IsBridge() && !n.IsHost() && !n.IsNone() && !n.IsContainer() && len(input.NetworkAliases) > 0 {
451453
endpointConfig := &network.EndpointSettings{
452454
Aliases: input.NetworkAliases,
453455
}

0 commit comments

Comments
 (0)