Merge pull request #237 from lbbniu/feat/lbbniu/golangci-lint

feat: 添加golangci-lint，并修复lint检查

Author: aceld

.github/workflows/reviewdog.yml

@@ -0,0 +1,20 @@
+name: reviewdog
+on: [pull_request]
+jobs:
+  golangci-lint:
+    runs-on: ubuntu-latest
+    name: runner / golangci-lint
+    steps:
+      - name: Check out code into the Go module directory
+        uses: actions/checkout@v3
+      - name: golangci-lint
+        uses: reviewdog/action-golangci-lint@v2
+        with:
+          github_token: ${{ secrets.github_token }}
+          # Change reviewdog reporter if you need [github-pr-check,github-check,github-pr-review].
+          reporter: github-pr-review
+          # Report all results.
+          filter_mode: nofilter
+          # Exit with 1 when it finds at least one finding.
+          fail_on_error: true
+          #golangci_lint_flags

.golangci.yaml

@@ -0,0 +1,28 @@
+run:
+  timeout: 30m
+  skip-dirs:
+  - examples
+
+linters:
+  disable-all: true
+  enable:
+  #- unused
+  - ineffassign
+  - goimports
+  - gofmt
+  - misspell
+  - unparam
+  - unconvert
+  - govet
+  # - errcheck
+  - staticcheck
+
+linters-settings:
+  staticcheck:
+    go: "1.16"
+    checks:
+    - "all"
+    - "-SA1019"
+
+  unused:
+    go: "1.16"

logo/zinxlogo.go

@@ -2,6 +2,7 @@ package logo
 
 import (
 	"fmt"
+
 	"github.com/aceld/zinx/zconf"
 )
 

zasync_op/async_op_result.go

@@ -3,6 +3,7 @@
 	@Author：14March
 	@File：async_op_result.go
 */
+
 package zasync_op
 
 import (

zasync_op/async_worker.go

@@ -3,6 +3,7 @@
 	@Author：14March
 	@File：async_worker.go
 */
+
 package zasync_op
 
 import "github.com/aceld/zinx/zlog"

zconf/globalobj.go

@@ -8,14 +8,15 @@ package zconf
 import (
 	"encoding/json"
 	"fmt"
-	"github.com/aceld/zinx/zlog"
-	"github.com/aceld/zinx/zutils/commandline/args"
-	"github.com/aceld/zinx/zutils/commandline/uflag"
 	"io/ioutil"
 	"os"
 	"reflect"
 	"testing"
 	"time"
+
+	"github.com/aceld/zinx/zlog"
+	"github.com/aceld/zinx/zutils/commandline/args"
+	"github.com/aceld/zinx/zutils/commandline/uflag"
 )
 
 const (

zdecoder/crc.go

@@ -61,10 +61,9 @@ var crc16_l = []byte{
 func GetCrC(buff []byte) []byte {
 	var hi uint16 = 0x00ff
 	var low uint16 = 0x00ff
-	var pos uint16 = 0
 
 	for i := 0; i < len(buff); i++ {
-		pos = (low ^ uint16(buff[i])) & 0x00ff
+		pos := (low ^ uint16(buff[i])) & 0x00ff
 		low = hi ^ uint16(crc16_h[pos])
 		hi = uint16(crc16_l[pos])
 	}

zdecoder/htlvcrcdecoder.go

@@ -44,9 +44,10 @@ package zdecoder
 
 import (
 	"encoding/hex"
+	"math"
+
 	"github.com/aceld/zinx/ziface"
 	"github.com/aceld/zinx/zlog"
-	"math"
 )
 
 const HEADER_SIZE = 5

zdecoder/ltvdecoder_little.go

@@ -51,8 +51,9 @@ package zdecoder
 import (
 	"bytes"
 	"encoding/binary"
-	"github.com/aceld/zinx/ziface"
 	"math"
+
+	"github.com/aceld/zinx/ziface"
 )
 
 const LTV_HEADER_SIZE = 8 //表示TLV空包长度

zdecoder/tlvdecoder.go

@@ -52,8 +52,9 @@ package zdecoder
 import (
 	"bytes"
 	"encoding/binary"
-	"github.com/aceld/zinx/ziface"
 	"math"
+
+	"github.com/aceld/zinx/ziface"
 )
 
 const TLV_HEADER_SIZE = 8 //表示TLV空包长度