-
Notifications
You must be signed in to change notification settings - Fork 205
Update SMSmissingROWIDs.py #1336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updated for both new artifact format and query changes.
Removed unused imports
|
Great information on your repo page, and thanks for referencing the LEAPPs too! A couple notes: Timestamp adjustment
Test DataDo you know of any publicly available valid test data that we can use in our test library to allow for continuous testing? |
|
I submitted this pull request, this is just my other account. Glad the repo is helpful, this has been a fun little project. I don't think those changes will be a problem at all, I started into it but caught up with some other things. It's interesting the changes and improvements, it's been a minute since I submitted anything here - hence, all the other changes to this artifact as well. I don't know a test dataset offhand that includes this newest change.. basically this covers the most recent sent/received iMessages being removed making a difference between the max ROWID and the sqlite_sequence number for the message table. You can recreate this scenario by adjusting the seq so it's higher and zipping the appropriate folder structure. It's a quick test in a bind. But, again, I'll keep looking at the timestamps. Thanks for all you do! |
Changes to use convert_cocoa_core_data_ts_to_utc and add rows of the raw message.date values
Bad indent correction.
|
I reviewed timestamp conversions under iLEAPP/scripts/ilapfuncs.py - is there currently any other handling of timestamp values that may be 9 digit (seconds) or 18 digit (nanoseconds)? I may have missed something that you have defined. Having not seen anything in ilapfuncs.py that accounts for the possible timestamp difference and going away from the case statement I originally had the def fix_ts(val) worked here, for just this artifact. I've been working this query for some time now and Apple has adjusted timestamp recordings within the sms.db over the years so handling both possible timestamps is more universal for datasets. |
|
@Johann-PLW has done the work on those timestamp conversions and would know better |
Updated for both new artifact format and query changes. Additional information is available here: https://github.com/MetadataForensics/RowIDetective